zhoufek commented on pull request #15603: URL: https://github.com/apache/beam/pull/15603#issuecomment-941032675
I've updated `_ParallelTriggerFn` to implement `may_lose_data` so that `AfterAll` and `AfterAny` inherit it. Like its implementation of `should_fire` and `on_fire`, it bases the decision on `_ParallelTriggerFn.combine_op`, which are set in the implementations. This should make it clearer how `may_lose_data` relates to whether or not a trigger may finish, specifically to the return value of `on_fire`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
