riteshghorse commented on pull request #15657:
URL: https://github.com/apache/beam/pull/15657#issuecomment-942776133


   PTAL.
   
   1. Changed sampler to take in `time`. 
   2. Added `TransformTotalTime` calculation.
   3. Sampler test. verbose but works as expected.
   
   Please ignore the `exec.Pardo` for now. Major changes to metrics package 
only.
   Is there a way we can delete the `Store.stateRegistry` allocated with make 
and append ? Have a indexed array for it creates problem in assigning the 
`Struct value to a map field`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to