riteshghorse commented on pull request #15657: URL: https://github.com/apache/beam/pull/15657#issuecomment-945959699
PTAL. The second test works as expected. The precommit here is failing in the `metrics_test`. When we do the metrics dump we expected only the counter values earlier. But now the addition of [MsecsInt64](https://github.com/apache/beam/blob/57c81d7aedb1c334fa17dc399bd75af808ed8901/sdks/go/pkg/beam/core/metrics/store.go#L97) to the [Extractor](https://github.com/apache/beam/blob/57c81d7aedb1c334fa17dc399bd75af808ed8901/sdks/go/pkg/beam/core/metrics/store.go#L89) will dump execution state metric value as well and the test fails. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
