riteshghorse commented on pull request #15657: URL: https://github.com/apache/beam/pull/15657#issuecomment-947075018
PTAL. There is no lock contention in `SetPTransformState` now because we are using atomic.Value for updating the state and pid. However, this has been compensated in the allocs/op. It changed from 0 to 2 allocs/op. There is a lock contention in case of `s.Sample` . If we can use normal `int` for storing the time instead of `time.Duration` then we can get rid of that lock as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
