ilya-kozyrev commented on a change in pull request #15714: URL: https://github.com/apache/beam/pull/15714#discussion_r734566633
########## File path: playground/backend/internal/cache/cache.go ########## @@ -0,0 +1,52 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +package cache + +import ( + "context" + "github.com/google/uuid" + "os" + "time" +) + +type SubKey string + +const ( + SubKey_Status SubKey = "STATUS" + SubKey_RunOutput SubKey = "RUN_OUTPUT" + SubKey_CompileOutput SubKey = "COMPILE_OUTPUT" +) + +type Cache interface { + // GetValue returns value from cache by pipelineId and subKey. + GetValue(ctx context.Context, pipelineId uuid.UUID, subKey SubKey) (interface{}, error) + + // SetValue adds value to cache by pipelineId and subKey. Review comment: Removed auto expiration from setValue. Better to use explicit method setExpTime ########## File path: playground/backend/internal/cache/local_cache.go ########## @@ -0,0 +1,122 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +package cache + +import ( + "context" + "fmt" + "github.com/google/uuid" + "sync" + "time" +) + +const cleanupInterval = 5 * time.Second + +type LocalCache struct { + sync.RWMutex + cleanupInterval time.Duration + items map[uuid.UUID]map[SubKey]interface{} + pipelinesExpiration map[uuid.UUID]time.Time +} + +func newLocalCache(ctx context.Context) *LocalCache { + items := make(map[uuid.UUID]map[SubKey]interface{}) + pipelinesExpiration := make(map[uuid.UUID]time.Time) + ls := &LocalCache{ + cleanupInterval: cleanupInterval, + items: items, + pipelinesExpiration: pipelinesExpiration, + } + + go ls.startGC() + return ls + +} + +func (lc *LocalCache) GetValue(ctx context.Context, pipelineId uuid.UUID, subKey SubKey) (interface{}, error) { + lc.RLock() + value, found := lc.items[pipelineId][subKey] + if !found { + lc.RUnlock() + return nil, fmt.Errorf("value with pipelineId: %s and subKey: %s not found", pipelineId, subKey) + } + expTime := lc.pipelinesExpiration[pipelineId] + lc.RUnlock() + + if expTime.Before(time.Now()) { + lc.Lock() + delete(lc.items[pipelineId], subKey) + delete(lc.pipelinesExpiration, pipelineId) + lc.Unlock() + return nil, fmt.Errorf("value with pipelineId: %s and subKey: %s is expired", pipelineId, subKey) + } + + return value, nil +} + +func (lc *LocalCache) SetValue(ctx context.Context, pipelineId uuid.UUID, subKey SubKey, value interface{}) error { + lc.Lock() + defer lc.Unlock() + + _, ok := lc.items[pipelineId] + if !ok { + lc.items[pipelineId] = make(map[SubKey]interface{}) + lc.pipelinesExpiration[pipelineId] = time.Now().Add(time.Hour) + } + lc.items[pipelineId][subKey] = value + return nil +} + +func (lc *LocalCache) SetExpTime(ctx context.Context, pipelineId uuid.UUID, expTime time.Duration) error { Review comment: added error handling for not presented pipelines -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
