pabloem commented on pull request #15714: URL: https://github.com/apache/beam/pull/15714#issuecomment-951185192
I will merge, but - the documentation should be part of the interface, right? Not part of the LocalCache class implementation e.g. the following comments should be in cache.go, not local_cache.go, right? TODO(@ilya-kozyrev / @pavel-avilov ) - can you add the documentation on the interface in a follow up change? Thanks! ``` // SetValue puts element to cache. // If a particular pipelineId does not contain in the cache, SetValue creates a new element for this pipelineId without expiration time. // Use SetExpTime to set expiration time for cache elements. // If data for a particular pipelineId is already contained in the cache, SetValue sets or updates the value for the specific subKey. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
