ihji commented on a change in pull request #15606:
URL: https://github.com/apache/beam/pull/15606#discussion_r736863218
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ExternalTransformBuilder.java
##########
@@ -44,4 +47,12 @@
/** Builds the transform after it has been configured. */
PTransform<InputT, OutputT> buildExternal(ConfigT configuration);
+
+ /**
+ * List the dependencies needed for this transform. Jars from classpath are
used by default when
Review comment:
> Is this in addition to the dependencies provided through the
CLASSPATH/filesToStage option or should this provide the full set of
dependencies used for this transform ?
It doesn't include dependencies from classpath by default.
>
> Also, should this be a complete list, including transitive dependencies ?
Yes, it should return a complete list. We just put whatever the method
returns into the dependencies field in the environment proto. For better
usability, we could provide some utility functions in the future such as
automatically downloading jars from artifact specification string or get all
transitive dependencies from artifact's pom file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
