chamikaramj commented on a change in pull request #15692:
URL: https://github.com/apache/beam/pull/15692#discussion_r737019756
##########
File path: sdks/python/apache_beam/runners/dataflow/internal/apiclient.py
##########
@@ -572,7 +572,8 @@ def _stage_resources(self, pipeline, options):
raise RuntimeError('The --temp_location option must be specified.')
resources = []
- hashes = {}
+ path_hashes = {}
Review comment:
I still don't understand why we need to de-dup using path in addition to
the hash. How can two artifacts that have the same path not have the same hash
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
