chamikaramj commented on a change in pull request #15692:
URL: https://github.com/apache/beam/pull/15692#discussion_r737688389
##########
File path: sdks/python/apache_beam/runners/dataflow/internal/apiclient.py
##########
@@ -572,7 +572,8 @@ def _stage_resources(self, pipeline, options):
raise RuntimeError('The --temp_location option must be specified.')
resources = []
- hashes = {}
+ path_hashes = {}
Review comment:
I see. In that case, can we re-arrange this to following form :
If (hash available):
dedup based on hash
else if (path available)
dedup based on path
Also let's add a comment describing the reason for having the use the path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
