pabloem commented on a change in pull request #15832:
URL: https://github.com/apache/beam/pull/15832#discussion_r740629497
##########
File path:
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java
##########
@@ -1060,53 +1060,36 @@ public void populateDisplayData(DisplayData.Builder
builder) {
getUpperBound() - getLowerBound() >= getNumPartitions(),
"The specified number of partitions is more than the difference
between upper bound and lower bound");
- if (getUpperBound() == MAX_VALUE || getLowerBound() == 0) {
Review comment:
in this case, the default values will be used. We could change the
parameter to be `Long` instead of `long` and fail with nulls. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
