pabloem commented on a change in pull request #15832:
URL: https://github.com/apache/beam/pull/15832#discussion_r740629497
##########
File path:
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java
##########
@@ -1060,53 +1060,36 @@ public void populateDisplayData(DisplayData.Builder
builder) {
getUpperBound() - getLowerBound() >= getNumPartitions(),
"The specified number of partitions is more than the difference
between upper bound and lower bound");
- if (getUpperBound() == MAX_VALUE || getLowerBound() == 0) {
Review comment:
in this case, the default values will be used. We could change the
parameter to be `Long` instead of `long` and fail with nulls. WDYT?
##########
File path:
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java
##########
@@ -1060,53 +1060,36 @@ public void populateDisplayData(DisplayData.Builder
builder) {
getUpperBound() - getLowerBound() >= getNumPartitions(),
"The specified number of partitions is more than the difference
between upper bound and lower bound");
- if (getUpperBound() == MAX_VALUE || getLowerBound() == 0) {
Review comment:
done
##########
File path: CHANGES.md
##########
@@ -70,6 +70,11 @@
* X behavior was changed
([BEAM-X](https://issues.apache.org/jira/browse/BEAM-X)).
* A new URN convention was adopted for cross-language transforms and existing
URNs were updated. This may break advanced use-cases, for example, if a custom
expansion service is used to connect diffrent Beam Java and Python versions.
([BEAM-12047](https://issues.apache.org/jira/browse/BEAM-12047)).
+* We changed the data type for ranges in `JdbcIO.readWithPartitions` from
`int` to `long`
+ [BEAM-13149](https://issues.apache.org/jira/browse/BEAM-13149). This is a
relatively minor
+ breaking change, which we're implementing to improve the usability of the
transform without increasing cruft.
+ This transform is relatively new, so we may implement other breaking
changes in the future to improve its usability.
+>>>>>>> a24811cef9 (Documenting change as a breaking change)
Review comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
