TheNeuralBit commented on a change in pull request #15836:
URL: https://github.com/apache/beam/pull/15836#discussion_r742051238
##########
File path: sdks/java/extensions/sql/build.gradle
##########
@@ -53,10 +53,12 @@ def hadoopVersions = [
hadoopVersions.each {kv -> configurations.create("hadoopVersion$kv.key")}
dependencies {
+ // Required for processing Calcite's immutable annotations
Review comment:
Ok to be sure I ran internal tests on this, which including building and
running some templates. The templates didn't need to add
`org.immutables.value:value` in order to build, so it looks like we won't be
passing this issue along.
##########
File path: sdks/java/extensions/sql/build.gradle
##########
@@ -53,10 +53,12 @@ def hadoopVersions = [
hadoopVersions.each {kv -> configurations.create("hadoopVersion$kv.key")}
dependencies {
+ // Required for processing Calcite's immutable annotations
Review comment:
Ok to be sure I ran internal tests on this, which including building and
running some templates. The templates didn't need to add
`org.immutables.value:value` in order to build, so it looks like we won't be
passing this issue along. I'll just add a TODO and jira to follow-up on this.
##########
File path: sdks/java/extensions/sql/build.gradle
##########
@@ -53,10 +53,12 @@ def hadoopVersions = [
hadoopVersions.each {kv -> configurations.create("hadoopVersion$kv.key")}
dependencies {
+ // Required for processing Calcite's immutable annotations
Review comment:
Hm well adding it under `annotationProcessor` doesn't alleviate the
issue, but `compileOnly` (by itself) does.
##########
File path: sdks/java/extensions/sql/build.gradle
##########
@@ -53,10 +53,12 @@ def hadoopVersions = [
hadoopVersions.each {kv -> configurations.create("hadoopVersion$kv.key")}
dependencies {
+ // Required for processing Calcite's immutable annotations
Review comment:
Ok to be sure I ran internal tests on this, which including building and
running some templates. The templates didn't need to add
`org.immutables.value:value` in order to build, so it looks like we won't be
passing this issue along.
##########
File path: sdks/java/extensions/sql/build.gradle
##########
@@ -53,10 +53,12 @@ def hadoopVersions = [
hadoopVersions.each {kv -> configurations.create("hadoopVersion$kv.key")}
dependencies {
+ // Required for processing Calcite's immutable annotations
Review comment:
Ok to be sure I ran internal tests on this, which including building and
running some templates. The templates didn't need to add
`org.immutables.value:value` in order to build, so it looks like we won't be
passing this issue along. I'll just add a TODO and jira to follow-up on this.
##########
File path: sdks/java/extensions/sql/build.gradle
##########
@@ -53,10 +53,12 @@ def hadoopVersions = [
hadoopVersions.each {kv -> configurations.create("hadoopVersion$kv.key")}
dependencies {
+ // Required for processing Calcite's immutable annotations
Review comment:
Hm well adding it under `annotationProcessor` doesn't alleviate the
issue, but `compileOnly` (by itself) does.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
