lostluck commented on a change in pull request #15887:
URL: https://github.com/apache/beam/pull/15887#discussion_r743256891
##########
File path: sdks/go/pkg/beam/core/runtime/metricsx/metricsx.go
##########
@@ -126,12 +151,12 @@ func extractCounterValue(reader *bytes.Reader) (int64,
error) {
return value, nil
}
-func extractMsecValue(reader *bytes.Reader) (metrics.MsecValue, error) {
+func extractMsecValue(reader *bytes.Reader) (time.Duration, error) {
value, err := coder.DecodeVarInt(reader)
if err != nil {
- return metrics.MsecValue{}, err
+ return time.Millisecond, err
Review comment:
You can simply return `0` here. The compiler will turn the untyped
integer constant to `time.Duration` for you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
