lostluck commented on a change in pull request #15887:
URL: https://github.com/apache/beam/pull/15887#discussion_r743266975
##########
File path: sdks/go/pkg/beam/core/metrics/metrics.go
##########
@@ -754,6 +770,19 @@ func (r MsecResult) Result() MsecValue {
return r.Attempted
}
+// Name returns the Name of this Gauge.
+func (r MsecResult) Name() string {
+ return r.Key.Name
+}
+
+// Namespace returns the Namespace of this Gauge.
+func (r MsecResult) Namespace() string {
+ return r.Key.Namespace
+}
Review comment:
Msec results can't have any name or namespaces (or at the very least,
won't have them correctly populated here). return `""` instead for now.
Also, please fix the copypasta "Gauge" references.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
