apilloud commented on a change in pull request #15915:
URL: https://github.com/apache/beam/pull/15915#discussion_r746208690
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamCalcRel.java
##########
@@ -112,11 +119,19 @@
private static final long MILLIS_PER_DAY = 86400000L;
private static final ParameterExpression rowParam =
Expressions.parameter(Row.class, "row");
+ private PTransform<PCollection<BeamCalcRelError>, POutput> errorsTransformer;
+ private static final TupleTag<Row> rows = new TupleTag<Row>() {};
+ private static final TupleTag<BeamCalcRelError> errors = new
TupleTag<BeamCalcRelError>() {};
public BeamCalcRel(RelOptCluster cluster, RelTraitSet traits, RelNode input,
RexProgram program) {
super(cluster, traits, input, program);
}
+ @Override
+ public void withErrorsTransformer(PTransform<PCollection<BeamCalcRelError>,
POutput> ptransform) {
Review comment:
Should this be an argument to `buildPTransform` instead? It seems kind
of roundabout to be doing it this way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
