lukecwik commented on a change in pull request #15917:
URL: https://github.com/apache/beam/pull/15917#discussion_r747745793
##########
File path: model/fn-execution/src/main/proto/beam_fn_api.proto
##########
@@ -296,6 +296,14 @@ message ProcessBundleRequest {
// (Optional) A list of cache tokens that can be used by an SDK to reuse
// cached data returned by the State API across multiple bundles.
repeated CacheToken cache_tokens = 2;
+
+ // (optional) Elements to be processed with the bundle. Either all or
+ // none of the bundle elements should be included in the
ProcessBundleRequest.
+ // This elements embedding is to achieve better Fn API efficiency for bundles
+ // that contain only small amount of data and are cheap to be processed on
the
+ // SDK harness side. See more at
+ // https://s.apache.org/beam-fn-api-control-data-embedding.
+ Elements elements = 3;
Review comment:
What do you think of my first comment which updated the existing text as
well?
##########
File path: model/fn-execution/src/main/proto/beam_fn_api.proto
##########
@@ -327,6 +335,13 @@ message ProcessBundleResponse {
// payload field with the bytes specified here.
map<string, bytes> monitoring_data = 5;
+ // (optional) Output elements of the processed bundle. Either all or
+ // none of the bundle elements should be included in the
ProcessBundleResponse.
+ // This elements embedding is to achieve better Fn API efficiency for bundles
+ // that only produce small amount of outputs. See more at
+ // https://s.apache.org/beam-fn-api-control-data-embedding.
Review comment:
What do you think of my first comment which updated the existing text as
well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
