lukecwik commented on a change in pull request #15917:
URL: https://github.com/apache/beam/pull/15917#discussion_r747746463
##########
File path: model/fn-execution/src/main/proto/beam_fn_api.proto
##########
@@ -296,6 +296,15 @@ message ProcessBundleRequest {
// (Optional) A list of cache tokens that can be used by an SDK to reuse
// cached data returned by the State API across multiple bundles.
repeated CacheToken cache_tokens = 2;
+
+ // (optional) Elements to be processed with the bundle. Either all or
+ // none of the bundle elements should be included in the
ProcessBundleRequest.
+ // This elements embedding is to achieve better Fn API efficiency for bundles
+ // that contain only small amount of data and are cheap to be processed on
the
+ // SDK harness side. This field can be set only if the SDK declares that it
+ // supports the CONTROL_REQUEST_ELEMENTS_EMBEDDING capability. See more at
Review comment:
```suggestion
// supports the beam:protocol:control_request_elements_embedding:v1
capability. See more at
```
Note that the ENUM can change but its contents of string can't so best to
use it within the comment.
##########
File path: model/fn-execution/src/main/proto/beam_fn_api.proto
##########
@@ -327,6 +336,15 @@ message ProcessBundleResponse {
// payload field with the bytes specified here.
map<string, bytes> monitoring_data = 5;
+ // (optional) Output elements of the processed bundle. Either all or
+ // none of the bundle elements should be included in the
ProcessBundleResponse.
+ // This embedding is to achieve better efficiency for bundles that only
+ // contain small amounts of data. his field can be set only if the runner
+ // declares that it supports the CONTROL_RESPONSE_ELEMENTS_EMBEDDING
Review comment:
```suggestion
// declares that it supports the
beam:protocol:control_response_elements_embedding:v1
```
Note that the ENUM can change but its contents of string can't so best to
use it within the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
