chamikaramj commented on a change in pull request #15817:
URL: https://github.com/apache/beam/pull/15817#discussion_r747639789
##########
File path: sdks/python/apache_beam/coders/typecoders.py
##########
@@ -80,12 +80,12 @@ def MakeXyzs(v):
class CoderRegistry(object):
"""A coder registry for typehint/coder associations."""
- def __init__(self, fallback_coder=None):
Review comment:
This change is backwards incompatible. Can we keep the extra keyword arg
and the default here ?
##########
File path: sdks/python/apache_beam/coders/typecoders.py
##########
@@ -97,8 +97,10 @@ def register_standard_coders(self, fallback_coder):
self._register_coder_internal(typehints.DictConstraint, coders.MapCoder)
# Default fallback coders applied in that order until the first matching
# coder found.
- default_fallback_coders = [coders.ProtoCoder, coders.FastPrimitivesCoder]
- self._fallback_coder = fallback_coder or FirstOf(default_fallback_coders)
+ default_fallback_coders = [
+ coders.ProtoCoder, coders.ProtoPlusCoder, coders.FastPrimitivesCoder
Review comment:
Can we change the list fo following so that matching order does not
change for other types ?
[coders.ProtoCoder, coders.FastPrimitivesCoder, coders.ProtoPlusCoder]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
