dpcollins-google commented on a change in pull request #15817:
URL: https://github.com/apache/beam/pull/15817#discussion_r747887841
##########
File path: sdks/python/apache_beam/coders/typecoders.py
##########
@@ -97,8 +97,10 @@ def register_standard_coders(self, fallback_coder):
self._register_coder_internal(typehints.DictConstraint, coders.MapCoder)
# Default fallback coders applied in that order until the first matching
# coder found.
- default_fallback_coders = [coders.ProtoCoder, coders.FastPrimitivesCoder]
- self._fallback_coder = fallback_coder or FirstOf(default_fallback_coders)
+ default_fallback_coders = [
+ coders.ProtoCoder, coders.ProtoPlusCoder, coders.FastPrimitivesCoder
Review comment:
No we can't, FastPrimitivesCoder contains PickleCoder and claims to work
for every type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
