tvalentyn commented on a change in pull request #15927:
URL: https://github.com/apache/beam/pull/15927#discussion_r749756944
##########
File path: sdks/python/container/Dockerfile
##########
@@ -38,11 +36,10 @@ RUN apt-get update && \
# Install required packages for Beam Python SDK and common dependencies used
by users.
####
-# SDK dependencies not listed in base_image_requirements.txt will be installed
-# when we install SDK with pip below.
COPY target/base_image_requirements.txt /tmp/base_image_requirements.txt
RUN \
- pip install -r /tmp/base_image_requirements.txt && \
+ # use --no-deps to ensure the list includes all transitive dependencies.
+ pip install --no-deps -r /tmp/base_image_requirements.txt && \
Review comment:
it's always a possibility that future deps will cause some problems; but
as far as this line of code is concerned, future deps should also be included
in base_image_requirements, after the requirement list is regenerated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
