tvalentyn commented on a change in pull request #15927:
URL: https://github.com/apache/beam/pull/15927#discussion_r749759256



##########
File path: sdks/python/container/Dockerfile
##########
@@ -67,13 +64,33 @@ RUN ln -s /usr/bin/ccache /usr/local/bin/gcc
 RUN ccache --set-config=sloppiness=file_macro && ccache 
--set-config=hash_dir=false
 
 ####
-# Install Apache Beam SDK
+# Install Apache Beam SDK. Use --no-deps and pip check to verify that all
+# necessary dependencies are specified in base_image_requiremetns.txt.
 ####
 COPY target/apache-beam.tar.gz /opt/apache/beam/tars/
-RUN pip install -v /opt/apache/beam/tars/apache-beam.tar.gz[gcp]
+RUN pip install --no-deps -v /opt/apache/beam/tars/apache-beam.tar.gz[gcp]
+RUN pip check
 
-COPY target/license_scripts /tmp/license_scripts/
+COPY target/LICENSE /opt/apache/beam/
+COPY target/LICENSE.python /opt/apache/beam/
+COPY target/NOTICE /opt/apache/beam/
+COPY target/launcher/linux_amd64/boot /opt/apache/beam/
+
+# Log complete list of what exact packages and versions are installed.
+RUN pip freeze --all
+# Make sure there are no conflicting dependencies.
+RUN pip check

Review comment:
       yup.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to