y1chi commented on a change in pull request #16037:
URL: https://github.com/apache/beam/pull/16037#discussion_r763244259
##########
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/control/FinalizeBundleHandler.java
##########
@@ -65,45 +59,13 @@ public static CallbackRegistration create(
public abstract BundleFinalizer.Callback getCallback();
}
- private static final Logger LOG =
LoggerFactory.getLogger(FinalizeBundleHandler.class);
private final ConcurrentMap<String, Collection<CallbackRegistration>>
bundleFinalizationCallbacks;
private final PriorityQueue<TimestampedValue<String>> cleanUpQueue;
- private final Future<Void> cleanUpResult;
- public FinalizeBundleHandler(ExecutorService executorService) {
+ public FinalizeBundleHandler() {
this.bundleFinalizationCallbacks = new ConcurrentHashMap<>();
this.cleanUpQueue =
new PriorityQueue<>(11,
Comparator.comparing(TimestampedValue::getTimestamp));
- this.cleanUpResult =
Review comment:
FinalizeBundleHandler is created once per SDK harness process and reused
throughout the process lifetime so the cleanup should be kept to avoid memory
leak, we can suppress the warning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
