benWize commented on pull request #16200: URL: https://github.com/apache/beam/pull/16200#issuecomment-991362866
Hi @ibzib could you help me to review the current progress of this? I made this change https://github.com/apache/beam/blob/d57f7c1ef3fff6b458cb8514460e157486d5648f/sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/SqlOperatorMappingTable.java#L116 to be able to get the delimiter from the argList here https://github.com/apache/beam/blob/d57f7c1ef3fff6b458cb8514460e157486d5648f/sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/SqlOperators.java#L183 because when this cast occurs, the argList is lost https://github.com/apache/beam/blob/d57f7c1ef3fff6b458cb8514460e157486d5648f/sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/AggregateScanConverter.java#L235 Currently, the STRING_AGG's tests are passing https://ci-beam.apache.org/job/beam_PreCommit_SQL_Java11_Commit/3356/testReport/org.apache.beam.sdk.extensions.sql.zetasql/ZetaSqlDialectSpecTest/, but some checkstyle jobs are failing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
