dmvk commented on a change in pull request #15994:
URL: https://github.com/apache/beam/pull/15994#discussion_r768135907
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/state/FlinkStateInternals.java
##########
@@ -215,6 +216,22 @@ public void clearGlobalState() {
}
}
+ public List<ByteBuffer> getGlobalWindowStateKeys() {
Review comment:
`iterateUniqueKeys` doesn't solve the issue then, because you can not
rely on having AT LEAST SOME state for the key either.
For example, for some types of joins you might have cleaned up all state
already before EOW 🤷♂️ (the key is no longer present in the underlying state
backend)
Relying on internal detail that you have under control and that you can test
for is IMO a better option that relying on how users write their DoFns..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
