dmvk commented on a change in pull request #15994:
URL: https://github.com/apache/beam/pull/15994#discussion_r768438597
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/DoFnOperator.java
##########
@@ -340,11 +344,12 @@ public DoFnOperator(
timerInternals, windowingStrategy) {
@Override
public void setForWindow(InputT input, BoundedWindow window) {
- if (!window.equals(GlobalWindow.INSTANCE)) {
+ if (!window.equals(GlobalWindow.INSTANCE) ||
usesOnWindowExpiration) {
// Skip setting a cleanup timer for the global window as these
timers
// lead to potentially unbounded state growth in the runner,
depending on key
// cardinality. Cleanup for global window will be performed
upon arrival of the
// final watermark.
+ // In the case of OnWindowExpiration, we still set the timer.
Review comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
