daria-malkova commented on a change in pull request #16486:
URL: https://github.com/apache/beam/pull/16486#discussion_r782779320
##########
File path: playground/infrastructure/ci_cd.py
##########
@@ -77,11 +78,19 @@ def _check_envs():
def _run_ci_cd(step: config.Config.CI_CD_LITERAL, sdk: Sdk):
supported_categories = get_supported_categories(categories_file)
+ logging.info("Start of searching Playground examples ...")
examples = find_examples(root_dir, supported_categories, sdk)
+ logging.info("Finish of searching Playground examples")
+ logging.info("Count of found Playground examples: %s", len(examples))
Review comment:
Count -> Number will be better
##########
File path: playground/infrastructure/cd_helper.py
##########
@@ -44,8 +46,13 @@ def store_examples(self, examples: List[Example]):
"""
Store beam examples and their output in the Google Cloud.
"""
+ logger.info("Start of executing Playground examples ...")
asyncio.run(self._get_outputs(examples))
+ logger.info("Start of executing Playground examples ...")
Review comment:
It is the same as above on line 49, is it correct?
##########
File path: playground/infrastructure/ci_helper.py
##########
@@ -77,13 +79,15 @@ async def _verify_examples_status(self, examples:
List[Example]):
elif example.status == STATUS_RUN_TIMEOUT:
logging.error("Example: %s failed because of timeout",
example.filepath)
elif example.status == STATUS_COMPILE_ERROR:
- err = await client.get_compile_output(example.filepath)
+ err = await client.get_compile_output(example.pipeline_id)
logging.error(
"Example: %s has compilation error: %s", example.filepath, err)
elif example.status == STATUS_RUN_ERROR:
- err = await client.get_run_error(example.filepath)
- logging.error(
- "Example: %s has execution error: %s", example.filepath, err)
+ err = await client.get_run_error(example.pipeline_id)
+ logging.error("Example: %s has execution error: %s", example.filepath,
err)
verify_failed = True
+
+ logging.info("Count of verified Playground examples: %s / %s",
count_of_verified, len(examples))
+ logging.info("Count of Playground examples with some error: %s / %s",
len(examples) - count_of_verified, len(examples))
Review comment:
The same, Count -> Number
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
