KhaninArtur commented on a change in pull request #16486:
URL: https://github.com/apache/beam/pull/16486#discussion_r782903826
##########
File path: playground/infrastructure/cd_helper.py
##########
@@ -26,8 +26,10 @@
from pathlib import Path
from typing import List
+import tqdm
Review comment:
Could you please add the `tqdm` package to the requirements file?
##########
File path: playground/infrastructure/cd_helper.py
##########
@@ -82,11 +89,14 @@ def _save_to_cloud_storage(self, examples: List[Example]):
"""
self._storage_client = storage.Client()
self._bucket = self._storage_client.bucket(Config.BUCKET_NAME)
+ pbar = tqdm(total=len(examples))
for example in examples:
Review comment:
If I'm not mistaken, you can do just this:
```suggestion
for example in tqdm(examples):
```
And then you don't need to do `pbar.update` and `pbar.close` at the end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
