AnandInguva commented on a change in pull request #16448:
URL: https://github.com/apache/beam/pull/16448#discussion_r784366091
##########
File path: sdks/python/apache_beam/runners/portability/stager.py
##########
@@ -815,9 +876,10 @@ def _download_pypi_sdk_package(
language_version_tag='27',
language_implementation_tag='cp',
abi_tag='cp27mu',
- platform_tag='manylinux1_x86_64'):
+ platform_tag='manylinux1_x86_64',
+ package_name=None):
"""Downloads SDK package from PyPI and returns path to local path."""
- package_name = Stager.get_sdk_package_name()
+ package_name = package_name or Stager.get_sdk_package_name()
Review comment:
Yes, I wanted to combine them as they work in similar way. I made a
small change to this. This function would fetch apache beam sdk (source or whl)
by passing arguments to the `_download_pypi_package`. I didn't combine them for
now but will make a note of it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
