AnandInguva commented on a change in pull request #16448:
URL: https://github.com/apache/beam/pull/16448#discussion_r784366156
##########
File path: sdks/python/apache_beam/runners/portability/stager.py
##########
@@ -221,10 +221,17 @@ def create_job_resources(options, # type: PipelineOptions
setup_options.requirements_file, REQUIREMENTS_FILE))
# Populate cache with packages from the requirement file option and
# stage the files in the cache.
- (
- populate_requirements_cache if populate_requirements_cache else
- Stager._populate_requirements_cache)(
- setup_options.requirements_file, requirements_cache_path)
+ if setup_options.view_as(WorkerOptions).sdk_container_image is None:
+ # downloads the binary distributions
+ (
+ populate_requirements_cache if populate_requirements_cache else
Review comment:
Done
##########
File path: sdks/python/apache_beam/runners/portability/stager.py
##########
@@ -233,10 +240,17 @@ def create_job_resources(options, # type: PipelineOptions
resources.append(Stager._create_file_pip_requirements_artifact(tf.name))
# Populate cache with packages from PyPI requirements and stage
# the files in the cache.
- (
- populate_requirements_cache if populate_requirements_cache else
- Stager._populate_requirements_cache)(
- tf.name, requirements_cache_path)
+ if setup_options.view_as(WorkerOptions).sdk_container_image is None:
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
