KevinGG commented on a change in pull request #16555:
URL: https://github.com/apache/beam/pull/16555#discussion_r788151258
##########
File path: sdks/python/apache_beam/runners/interactive/interactive_beam.py
##########
@@ -220,6 +220,24 @@ def display_timezone(self, value):
"""
self._display_timezone = value
+ @property
+ def specified_cache_dir(self):
+ """The cache directory specified by the user.
+
+ Defaults to None.
+ """
+ return self._specified_cache_dir
+
+ @specified_cache_dir.setter
Review comment:
This setter doesn't seem to take effect immediately for existing cache
managers.
There can be 2 behaviors:
1. It overrides the cache dir for all existing
ie.current_env()._cache_managers, evict all existing cache files (locally or on
GCS, the GCS file deletion can be done in later PRs but add a TODO here) and
log warnings.
2. Notify the user that this only takes effect for new pipelines: restarting
the kernel or re-execute pipeline creation codes.
Also @rohdesamuel, which one do you think makes more sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
