KevinGG commented on a change in pull request #16555:
URL: https://github.com/apache/beam/pull/16555#discussion_r788159136



##########
File path: sdks/python/apache_beam/runners/interactive/interactive_beam.py
##########
@@ -220,6 +220,24 @@ def display_timezone(self, value):
     """
     self._display_timezone = value
 
+  @property
+  def specified_cache_dir(self):

Review comment:
       Maybe we should call this `cache_root` and describe it as the "Root path 
specified by the user to store interactive cache files"?
   
   Additionally, we might need to note the user that if a local path is 
specified, the runner/workers should be locally started and have "rw" access to 
the path. If DataflowRunner or FlinkRunner with a remote cluster is used, they 
should use GCS or other compatible distributed file systems.
   
   Also @rohdesamuel , what do you think?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to