VictorPlusC commented on a change in pull request #16601:
URL: https://github.com/apache/beam/pull/16601#discussion_r794840341
##########
File path:
sdks/python/apache_beam/runners/interactive/interactive_environment.py
##########
@@ -358,18 +361,33 @@ def get_cache_manager(self, pipeline,
create_if_absent=False):
create_if_absent is True, creates and returns a new file based cache
manager for the pipeline."""
cache_manager = self._cache_managers.get(str(id(pipeline)), None)
+ pipeline_runner = pipeline.runner._underlying_runner
if not cache_manager and create_if_absent:
- from apache_beam.runners.interactive import interactive_beam as ib
- if ib.options.cache_root:
- #TODO(victorhc): Handle the case when the path starts with "gs://"
- if ib.options.cache_root.startswith("gs://"):
- raise ValueError("GCS paths are not currently supported.")
- cache_dir = tempfile.mkdtemp(dir=ib.options.cache_root)
+ cache_root = self.options.cache_root
+ if cache_root:
+ if cache_root.startswith('gs://'):
+ cache_dir = self.assign_gcs_cache_dir(pipeline, cache_root)
Review comment:
As per your suggestions, the function has been finalized to
`_get_gcs_cache_dir` to denote that it is a private function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
