VictorPlusC commented on a change in pull request #16601:
URL: https://github.com/apache/beam/pull/16601#discussion_r794839138
##########
File path:
sdks/python/apache_beam/runners/interactive/interactive_environment.py
##########
@@ -675,3 +693,12 @@ def get_sql_chain(self, pipeline, set_user_pipeline=False):
pipeline)
chain.user_pipeline = pipeline
return chain
+
+ def get_gcs_cache_dir(self, pipeline, cache_dir):
Review comment:
Yes, I've now added two new unit tests:
1. `test_get_gcs_cache_dir_valid_path`: sends in a properly formatted
cache_root path and verifies it is formatted as expected
2. `test_get_gcs_cache_dir_invalid_path`: sends in an improperly formatted
cache_root path and verifies that a ValueError is raised
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
