lukecwik commented on a change in pull request #16688:
URL: https://github.com/apache/beam/pull/16688#discussion_r796939457
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -811,7 +811,9 @@ class BeamModulePlugin implements Plugin<Project> {
// Provided configuration to match Maven provided scope
project.configurations {
provided
- implementation.extendsFrom(provided)
+ compileOnly.extendsFrom(provided)
+ runtimeOnly.extendsFrom(provided)
+ testCompileOnly.extendsFrom(provided)
Review comment:
We shouldn't be adding to testCompileOnly.
Dependencies that are needed during test compilation should be declared
under testImplementation.
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
