lukecwik commented on a change in pull request #16688:
URL: https://github.com/apache/beam/pull/16688#discussion_r797029181
##########
File path: runners/flink/flink_runner.gradle
##########
@@ -151,6 +151,7 @@ dependencies {
implementation "org.apache.flink:flink-streaming-java_2.11:$flink_version"
// RocksDB state backend (included in the Flink distribution)
provided "org.apache.flink:flink-statebackend-rocksdb_2.11:$flink_version"
+ testImplementation
"org.apache.flink:flink-statebackend-rocksdb_2.11:$flink_version"
Review comment:
Does the test code reference classes from this dep (ditto for other deps
added this way)?
During test execution we should get `testRuntimeClasspath -> testRuntimeOnly
-> runtimeOnly -> provided`.
You can quickly check to see if compilation is satisfied with `./gradlew
testCompileJava`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
