jrmccluskey commented on a change in pull request #16671:
URL: https://github.com/apache/beam/pull/16671#discussion_r797963275
##########
File path: sdks/go/pkg/beam/core/runtime/xlangx/expand.go
##########
@@ -140,3 +142,67 @@ func QueryExpansionService(ctx context.Context, p
*HandlerParams) (*jobpb.Expans
}
return res, nil
}
+
+func startAutomatedExpansionService(gradleTarget string) (func() error,
string, error) {
+ jarPath, err := expansionx.GetBeamJar(gradleTarget, core.SdkVersion)
+ if err != nil {
+ return nil, "", err
+ }
+ serviceRunner, err := expansionx.NewExpansionServiceRunner(jarPath, "")
+ if err != nil {
+ return nil, "", err
+ }
+ err = serviceRunner.StartService()
+ if err != nil {
+ return nil, "", err
+ }
+ return serviceRunner.StopService, serviceRunner.Endpoint(), nil
+}
+
+// QueryAutomatedExpansionService submits an external transform to be expanded
by the
+// expansion service and then eagerly materializes the artifacts for staging.
The given
+// transform should be the external transform, and the components are any
additional
+// components necessary for the pipeline snippet.
+//
+// The address to be queried is determined by the Config field of the
HandlerParams after
+// the prefix tag indicating the automated service is in use.
+func QueryAutomatedExpansionService(ctx context.Context, p *HandlerParams)
(*jobpb.ExpansionResponse, error) {
+ // Strip auto: tag to get Gradle target
+ tag, target := parseAddr(p.Config)
+
+ stopFunc, address, err := startAutomatedExpansionService(target)
+ if err != nil {
+ return nil, err
+ }
+ defer stopFunc()
+
+ p.Config = address
+
+ res, err := QueryExpansionService(ctx, p)
+ if err != nil {
+ return nil, err
+ }
+
+ exp := &graph.ExpandedTransform{
+ Components: res.GetComponents(),
+ Transform: res.GetTransform(),
+ Requirements: res.GetRequirements(),
+ }
+
+ p.ext.Expanded = exp
+ // Put correct expansion address into edge
+ p.edge.External.ExpansionAddr = address
Review comment:
Yeah it's a little hacky, but how we can avoid the second materialize()
call easily.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
