jrmccluskey commented on a change in pull request #16671:
URL: https://github.com/apache/beam/pull/16671#discussion_r797966725
##########
File path: sdks/go/pkg/beam/transforms/sql/sql.go
##########
@@ -114,6 +116,9 @@ func Transform(s beam.Scope, query string, opts ...Option)
beam.PCollection {
if o.expansionAddr != "" {
expansionAddr = xlangx.Require(o.expansionAddr)
}
+ if expansionAddr == sqlx.DefaultExpansionAddr {
+ expansionAddr =
xlangx.UseAutomatedExpansionService(serviceGradleTarget)
Review comment:
We can do this but if we move the auto handling to the `sqlx` package
we'll have to drop some documenting comment in to explain that the default is
an automated service being spun up. Having things divorced between the two
packages isn't my favorite set-up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
