AydarZaynutdinov commented on a change in pull request #16703:
URL: https://github.com/apache/beam/pull/16703#discussion_r798374703
##########
File path: playground/backend/internal/preparers/scio_preparers.go
##########
@@ -50,9 +51,22 @@ func (builder *ScioPreparersBuilder) WithPackageRemover()
*ScioPreparersBuilder
return builder
}
+//WithImportRemover adds preparer to remove examples import from the code
+func (builder *ScioPreparersBuilder) WithImportRemover() *ScioPreparersBuilder
{
+ removeImportPreparer := Preparer{
+ Prepare: replace,
+ Args: []interface{}{builder.filePath, scioExampleImport, ""},
Review comment:
Maybe move`""` as a constant.
##########
File path:
playground/backend/internal/setup_tools/life_cycle/life_cycle_setuper.go
##########
@@ -35,12 +35,13 @@ const (
javaLogFilePlaceholder = "{logFilePath}"
goModFileName = "go.mod"
goSumFileName = "go.sum"
- scioProjectName = "scioproject"
- projectPath = "scioproject/src/main/scala/scioproject"
+ scioProjectName = "y"
+ projectPath = scioProjectName + "/src/main/scala/" +
scioProjectName
Review comment:
```suggestion
scioProjectPath = scioProjectName + "/src/main/scala/" +
scioProjectName
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
