KhaninArtur commented on a change in pull request #16703:
URL: https://github.com/apache/beam/pull/16703#discussion_r800513468
##########
File path:
playground/backend/internal/setup_tools/life_cycle/life_cycle_setuper.go
##########
@@ -176,6 +177,10 @@ func prepareSbtFiles(lc *fs_tool.LifeCycle, pipelineFolder
string, workingDir st
if err != nil {
return nil, err
}
+ _, err = exec.Command("cp", filepath.Join(workingDir,
scioCommonConstants), absFileFolderPath).Output()
Review comment:
Shouldn't "cp" be a constant like `cpCmd`?
##########
File path: playground/backend/ExampleData.scala
##########
@@ -0,0 +1,33 @@
+/*
Review comment:
I think we should move this file from the top level of the backend
folder, if we only need this in the `life_cycle`, let's move it there, what do
you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
