tvalentyn commented on a change in pull request #16633: URL: https://github.com/apache/beam/pull/16633#discussion_r801119086
########## File path: sdks/python/apache_beam/examples/complete/juliaset/requirements.txt ########## @@ -0,0 +1,18 @@ +############################################################################### +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +############################################################################### +numpy Review comment: This example already requires numpy in https://github.com/apache/beam/blob/16934836498bfe03cdcfb5f8b77f57c1a9bff795/sdks/python/apache_beam/examples/complete/juliaset/setup.py#L111 Given that you are modifying the example, users may be confused why numpy needs to be specified twice: in a requirements.txt file and in setup.py. Let's try to use a different pipeline for this test. You could create an example where a requirements file is used, or just a test pipeline that does something trivial, like checking whether a particular library is installed and doesn't do any data processing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
