tvalentyn commented on a change in pull request #16633:
URL: https://github.com/apache/beam/pull/16633#discussion_r801123351



##########
File path: sdks/python/apache_beam/runners/portability/stager_test.py
##########
@@ -765,7 +767,7 @@ def test_remove_dependency_from_requirements(self):
     self.assertEqual(['apache_beam\n', 'avro-python3\n', 'numpy\n'],
                      sorted(lines))
 
-  def _create_file(
+  def __populate_requitements_cache_fake(

Review comment:
       nit: you probably wanted a single underscore here. double underscore is 
reserved for triggering name mangling, see: 
https://www.python.org/dev/peps/pep-0008/#descriptive-naming-styles. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to