hoshimura commented on pull request #16735: URL: https://github.com/apache/beam/pull/16735#issuecomment-1033013506
Yes that is what made me do the PR in the first place, but rather because the previous implementation offered the same error for mid sized files. I never actually experienced the error for zerosized files IRL since my use case don't write them. But following the code I reasoned that the former code should error on zero buffers and midsize buffers alike. I haven't figured out if it is possible using the current fake client to trigger the same error as for the real client. Any suggestions appreciated! Den tis 8 feb. 2022 20:33Charles Chen ***@***.***> skrev: > So to clarify, is the new test saying that zero sized files don't work > using the real S3Client? > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/beam/pull/16735#issuecomment-1032985442>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AEAFBIC3Z652FUHD7KYIYI3U2FVXDANCNFSM5NSDIHIA> > . > Triage notifications on the go with GitHub Mobile for iOS > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> > or Android > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. > > You are receiving this because you authored the thread.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
