damccorm commented on a change in pull request #16815:
URL: https://github.com/apache/beam/pull/16815#discussion_r804156084



##########
File path: sdks/go/test/integration/integration.go
##########
@@ -123,6 +123,8 @@ var sparkFilters = []string{
        // The trigger and pane tests uses TestStream
        "TestTrigger.*",
        "TestPanes",
+       // [BEAM-13921]: Spark doesn't support side inputs to executable stages
+       "TestDebeziumIO_BasicRead",

Review comment:
       Thanks for doing this! Just for my edification, how was this failure 
introduced - did we add the integration test and its never worked on spark, or 
did we add a feature that then broke this test on Spark?
   
   I ask because I'm wondering if it would be worthwhile to introduce a policy 
that when the integration tests are changed, all post commit tests like this 
run automatically (or if we already have a policy like that and we just missed 
this). I much prefer robots checking stuff like this to humans remembering to 
run everything




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to