lostluck commented on a change in pull request #16815:
URL: https://github.com/apache/beam/pull/16815#discussion_r804189082
##########
File path: sdks/go/test/integration/integration.go
##########
@@ -123,6 +123,8 @@ var sparkFilters = []string{
// The trigger and pane tests uses TestStream
"TestTrigger.*",
"TestPanes",
+ // [BEAM-13921]: Spark doesn't support side inputs to executable stages
+ "TestDebeziumIO_BasicRead",
Review comment:
So, the tests listed in "integration.go" are only covering Go
integration tests. So, we added the test when we added the DebeziumIO transform
wrapper to the SDK.
In this case, we probably should have changes to the
.../go/test/integration/... directory to execute all the post commits as part
of the PR, to ensure they're run for all the runners on addition or change.
We don't usually do this for arbitrary SDK changes, because they're much
heavier weight than the various unit tests, and similarly, the Same Suite of
tests is run against the Python Portable Runner as the "GoPortable Precommit",
and cases where missing Runner features are tickled by the Go SDK itself, are
rare.
But that's why this got hit I guess: The issue is triggered from Java SDK
code, not Go SDK code.
To sum up, this is the post commits WAI, but we should trigger them eagerly
for PRs that are adding new tests to the suite.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
