KhaninArtur commented on a change in pull request #16826:
URL: https://github.com/apache/beam/pull/16826#discussion_r806005417
##########
File path: playground/backend/internal/cache/local/local_cache_test.go
##########
@@ -103,6 +105,23 @@ func TestLocalCache_GetValue(t *testing.T) {
want: nil,
wantErr: true,
},
+ {
+ // Test case with calling GetValue method with exist
value the expiration time of which has ended.
+ // As a result, want to receive an error.
Review comment:
Thank you for adding these comments, could you please also add comments
for other tests in these files? So every test in `local_cache_test.go` and
`redis_cache_test.go` has a corresponding comment😊
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
