daria-malkova commented on a change in pull request #16826:
URL: https://github.com/apache/beam/pull/16826#discussion_r809825401
##########
File path: playground/backend/internal/cache/local/local_cache_test.go
##########
@@ -103,6 +105,23 @@ func TestLocalCache_GetValue(t *testing.T) {
want: nil,
wantErr: true,
},
+ {
+ // Test case with calling GetValue method with existing
value that is expiring.
Review comment:
Unuseful comment
##########
File path: playground/backend/internal/cache/local/local_cache_test.go
##########
@@ -191,12 +230,29 @@ func TestLocalCache_SetExpTime(t *testing.T) {
expTime time.Duration
}
tests := []struct {
- name string
- fields fields
- args args
+ name string
+ fields fields
+ args args
+ wantErr bool
}{
{
name: "Set expiration time",
+ fields: fields{
+ cleanupInterval: cleanupInterval,
+ items: preparedItems,
+ pipelinesExpiration:
make(map[uuid.UUID]time.Time),
+ },
+ args: args{
+ ctx: context.Background(),
+ pipelineId: preparedId,
+ expTime: time.Minute,
+ },
+ wantErr: false,
+ },
+ {
+ // Test case with calling SetExpTime method with
pipelineId which not set in cache and expiration time.
Review comment:
ditto
##########
File path: playground/backend/internal/cache/local/local_cache_test.go
##########
@@ -159,6 +178,23 @@ func TestLocalCache_SetValue(t *testing.T) {
},
wantErr: false,
},
+ {
+ // Test case with calling SetValue method with
RunOutputIndex subKey.
Review comment:
ditto
##########
File path: playground/backend/internal/cache/redis/redis_cache_test.go
##########
@@ -68,7 +68,7 @@ func TestRedisCache_GetValue(t *testing.T) {
wantErr: true,
},
{
- name: "all success",
+ name: "get existing value",
Review comment:
Sometimes you have a name with an upper case letter, but sometimes with
lower case. Do the same everywhere
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
