johnjcasey commented on a change in pull request #16923:
URL: https://github.com/apache/beam/pull/16923#discussion_r813285559
##########
File path: sdks/python/apache_beam/coders/typecoders_test.py
##########
@@ -140,6 +140,14 @@ def test_list_coder(self):
self.assertIs(
list, type(expected_coder.decode(expected_coder.encode(values))))
+ def test_nullable_coder(self):
+ expected_coder = coders.NullableCoder(coders.BytesCoder())
+ real_coder = typecoders.registry.get_coder(
+ typehints.UnionConstraint([type(None), type(bytes)]))
Review comment:
Yep, I'll make the change in the test case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
