johnjcasey commented on a change in pull request #16923:
URL: https://github.com/apache/beam/pull/16923#discussion_r814854319
##########
File path:
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java
##########
@@ -776,11 +777,11 @@ private static Coder resolveCoder(Class deserializer) {
continue;
}
if (returnType.equals(byte[].class)) {
- return ByteArrayCoder.of();
+ return NullableCoder.of(ByteArrayCoder.of());
} else if (returnType.equals(Integer.class)) {
- return VarIntCoder.of();
+ return NullableCoder.of(VarIntCoder.of());
} else if (returnType.equals(Long.class)) {
- return VarLongCoder.of();
+ return NullableCoder.of(VarLongCoder.of());
Review comment:
I think exposing the Go Nullable coder is a good option. That way we
have it in the future, and we don't need to introduce work arounds in our code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
