mosche commented on a change in pull request #16894:
URL: https://github.com/apache/beam/pull/16894#discussion_r814587501
##########
File path:
sdks/java/io/amazon-web-services2/src/test/java/org/apache/beam/sdk/io/aws2/common/ClientConfigurationTest.java
##########
@@ -50,4 +52,28 @@ public void testSerialization() {
assertThat(deserializedConfig).isEqualTo(config);
}
+
+ @Test
+ public void testJsonSerialization() {
Review comment:
Initially I planned to ignore RetryConfiguration when serializing
to/from Json. While I don't see a use case yet, it might be misleading / error
prone. So added that capability and respective tests ...
`regionId` is purely internal and tested through the respective public api
using `region`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
