mosche commented on a change in pull request #16894:
URL: https://github.com/apache/beam/pull/16894#discussion_r814589022
##########
File path:
sdks/java/io/amazon-web-services2/src/test/java/org/apache/beam/sdk/io/aws2/s3/SSECustomerKeyTest.java
##########
@@ -54,4 +55,18 @@ public void buildWithArgs(String key, String algorithm,
String md5, String encod
assertEquals(algorithm, sseCustomerKey.getAlgorithm());
assertEquals(encodedMD5, sseCustomerKey.getMD5());
}
+
+ @Test
+ public void testJsonSerializeDeserialize() {
+ // default key created by S3Options.SSECustomerKeyFactory
+ SSECustomerKey emptyKey = SSECustomerKey.builder().build();
+
assertThat(jsonSerializeDeserialize(emptyKey)).isEqualToComparingFieldByField(emptyKey);
Review comment:
`SSECustomerKey` lacks an implementation of equals .... not sure why
it's not implemented using AutoValue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
